Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68879 )
Change subject: Revert "soc/intel/systemagent.c: Fix memory type reporting" ......................................................................
Revert "soc/intel/systemagent.c: Fix memory type reporting"
This reverts commit 9c2f3cc9d9b3b3b7cfe1e62a70ea3061ca6c15ac.
This broke the smihandler for no clear reason on some platforms.
Change-Id: I72da99c019241b627ce8b543937364a53a5fe97b Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/68879 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com Reviewed-by: Sean Rhodes sean@starlabs.systems --- M src/soc/intel/common/block/systemagent/systemagent.c 1 file changed, 23 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved Sean Rhodes: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c index ad60159..e74c118 100644 --- a/src/soc/intel/common/block/systemagent/systemagent.c +++ b/src/soc/intel/common/block/systemagent/systemagent.c @@ -201,8 +201,11 @@
sa_get_mem_map(dev, &sa_map_values[0]);
- /* top_of_ram -> TOLUD */ - reserved_ram_from_to(dev, index++, top_of_ram, sa_map_values[SA_TOLUD_REG]); + /* + * top_of_ram -> TOLUD: This contains TSEG which needs to be uncacheable + * for proper operation of the smihandler. + */ + mmio_from_to(dev, index++, top_of_ram, sa_map_values[SA_TOLUD_REG]);
/* 4GiB -> TOUUD */ upper_ram_end(dev, index++, sa_map_values[SA_TOUUD_REG]);