8 Jun
2019
8 Jun
'19
8:07 p.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33032 )
Change subject: acpigen: Add support for IndexField ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/33032/10/src/arch/x86/acpigen.c File src/arch/x86/acpigen.c:
https://review.coreboot.org/#/c/33032/10/src/arch/x86/acpigen.c@563 PS10, Line 563: =
shouldn't this be '+=' here?
I'd say it's correct as it is as offset is absolute, while names with variable bit field width are relative.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33032
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If66a627e64953696b0b68488256bd5c141e4c205
Gerrit-Change-Number: 33032
Gerrit-PatchSet: 10
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sat, 08 Jun 2019 18:07:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment