Attention is currently required from: YH Lin, Joey Peng, Nick Vaccaro.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61412 )
Change subject: mb/google/brya/var/tarlo: Enable USB A port on DB
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61412/comment/760acf41_ea8f3eaf
PS1, Line 7: Enable USB A port on DB
suggestion:
`Add new FW_CONFIG option for DB_USB`
https://review.coreboot.org/c/coreboot/+/61412/comment/60b1b462_458756b6
PS1, Line 7: tarlo
`taeko`
https://review.coreboot.org/c/coreboot/+/61412/comment/68e156e7_7d0b7c2f
PS1, Line 9: Tarlo
`Taeko`
File src/mainboard/google/brya/variants/taeko/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/61412/comment/92129d12_132a6c20
PS1, Line 497: 7
why 7? isn't 5 the next group #?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61412
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a43c256757f3fc4b53ba1f794587d6a00ba0aa5
Gerrit-Change-Number: 61412
Gerrit-PatchSet: 1
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Thu, 27 Jan 2022 18:45:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment