Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30282 )
Change subject: mb/google/hatch: Add SoC and EC asl files in DSDT
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/30282/8/src/mainboard/google/hatch/Kconfig
File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/30282/8/src/mainboard/google/hatch/Kconfig@1...
PS8, Line 15: SOC_INTEL_COFFEELAKE
whl boards need to select the cfl soc
thats because we don't have any WHL kconfig..
do we know CFL and WHL CPU Ids are same ? if yes then we are good else its not right way
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf1b1d7e34a7e863139c3583903f3b1e2cdc8da6
Gerrit-Change-Number: 30282
Gerrit-PatchSet: 8
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 21 Dec 2018 04:50:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment