Attention is currently required from: Bao Zheng.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61837 )
Change subject: soc/amd/cezanne: Allow to specify SPL table path in Kconfig
......................................................................
Patch Set 5:
(1 comment)
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/61837/comment/35335888_3b257ac8
PS4, Line 382: default n
i'd say that this kconfig option isn't needed and should be removed in a follow-up patch. […]
before CB:61836 broke that code path, the majolica image included the spl table. fixes are in CB:63314 and CB:61896
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61837
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a5ee335ea8808b595dc65ebafd15baedfbdd06e
Gerrit-Change-Number: 61837
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Avinash Alevoor
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Comment-Date: Sat, 02 Apr 2022 02:39:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment