Attention is currently required from: Nico Huber.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55231 )
Change subject: mb/starlabs/labtop: Unbreak master
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/starlabs/labtop/mainboard.c:
https://review.coreboot.org/c/coreboot/+/55231/comment/a304b3fc_ce6a44c0
PS1, Line 85: }
This looks like the default implementation. I don't think the author […]
Good point
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55231
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I379880b1165bb9da4117aa860dee111fba38a43f
Gerrit-Change-Number: 55231
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Star Labs
admin@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 04 Jun 2021 18:11:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment