build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56866 )
Change subject: elogtool: add "clear" command ......................................................................
Patch Set 1:
(15 comments)
File src/commonlib/bsd/elog.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/87a5bd6f_41ffeef3 PS1, Line 67: if (event->month > 0x12 || event->day > 0x31 || event->hour > 0x23 || that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/807416a9_a04614ee PS1, Line 99: } adding a line without newline at end of file
File util/cbfstool/elogtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/938f03f8_1d7b6c93 PS1, Line 120: static int elog_clear_events(struct buffer* buf) "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/f5ee200b_b0f10ad2 PS1, Line 124: void* data_offset; "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/daafe519_07efc9ea PS1, Line 135: * We calcualte the size of the "used" buffer, needed for ELOG_TYPE_LOG_CLEAR. 'calcualte' may be misspelled - perhaps 'calculate'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/d4de4862_f609fd3d PS1, Line 141: while ((const char*)(event) < buf->data + buf->size) { "(foo*)" should be "(foo *)"
File util/cbfstool/eventlog.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/f4470a62_92a9d606 PS1, Line 11: void eventlog_init_event(struct event_header* event, uint8_t type, const void* data, int data_size); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/1c49376c_cb40e3c4 PS1, Line 11: void eventlog_init_event(struct event_header* event, uint8_t type, const void* data, int data_size); "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/6835e0c5_8bb85ac0 PS1, Line 11: void eventlog_init_event(struct event_header* event, uint8_t type, const void* data, int data_size); "foo* bar" should be "foo *bar"
File util/cbfstool/eventlog.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/ee9ceac4_7a7c40b2 PS1, Line 638: void eventlog_init_event(struct event_header* event, uint8_t type, const void* data, int data_size) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/c0012e6f_34718503 PS1, Line 638: void eventlog_init_event(struct event_header* event, uint8_t type, const void* data, int data_size) "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/f3a7f88d_22b3f15c PS1, Line 638: void eventlog_init_event(struct event_header* event, uint8_t type, const void* data, int data_size) "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/a2a567a0_63932956 PS1, Line 645: elog_fill_timestamp(event, tm.tm_sec, tm.tm_min, tm.tm_hour, tm.tm_mday, tm.tm_mon, tm.tm_year); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/6e854695_30e24648 PS1, Line 648: void* ptr = (uint32_t*) &event[1]; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125890): https://review.coreboot.org/c/coreboot/+/56866/comment/ce275707_b410b83b PS1, Line 648: void* ptr = (uint32_t*) &event[1]; "foo* bar" should be "foo *bar"