Attention is currently required from: Rex-BC Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56797 )
Change subject: soc/mediatek/mt8192: initialize DFD
......................................................................
Patch Set 4:
(1 comment)
File src/soc/mediatek/mt8192/include/soc/dfd.h:
https://review.coreboot.org/c/coreboot/+/56797/comment/9bd8a336_11d966d9
PS4, Line 6: #define CPC_FLOW_CTRL_CFG 0x0C53A814
: #define RESET_ON_KEEP_EN BIT(17)
:
: /* DFD dump address and size need to be the same as defined in Kernel DTS. */
: #define DFD_DUMP_ADDRESS 0x6A000000
: #define DFD_DUMP_SIZE (1 * MiB)
Where are these – besides `RESET_ON_KEEP_EN` – used?
Sorry, missed one hunk [1].
[1]: https://review.coreboot.org/c/coreboot/+/56797/4/src/soc/mediatek/mt8192/soc...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56797
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39a4391c1d1e832d77b709f8f899bb1c6dcacd69
Gerrit-Change-Number: 56797
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Sat, 07 Aug 2021 09:10:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment