Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43864 )
Change subject: soc/intel/skylake: Enable HECI3 depending on devicetree configuration
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43864/2/src/soc/intel/skylake/chip....
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/43864/2/src/soc/intel/skylake/chip....
PS2, Line 234: Heci3Enabled
there is more than one heci device; HeciEnabled exists, too
I will upload another patch for this option later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f99d434dfee49a9783e38c3910b9391d479cb83
Gerrit-Change-Number: 43864
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jul 2020 18:12:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment