Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36321 )
Change subject: arch/x86/*.S: use defines instead of hardcoded values ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36321/1/src/arch/x86/include/arch/r... File src/arch/x86/include/arch/ram_segs.h:
https://review.coreboot.org/c/coreboot/+/36321/1/src/arch/x86/include/arch/r... PS1, Line 17: #define RAM_CODE_SEG 0x10 Can/Should we use these in the gdt itself? I guess it's a little hard in the current form where it's all assembly. However, We could probably pull that out into a C module and link it accordingly. Something for the future probably.