Attention is currently required from: Derek Huang, SH Kim, Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77115?usp=email )
Change subject: mb/google/nissa/var/pirrha: Update Kconfig for pirrha
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/77115/comment/1999c3ca_ac4d1a53 :
PS1, Line 9: - Override VBT_DATA_SIZE_KB=10 for bigger VBT file
: - Add support MIPI driver and DA7219 driver
: - Correct TPM I2C address
Listing several changes in a commit message is always a good indicator to split the commit. Please make it three separate commits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77115?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c9846e01da0e40770ea192891c0d1d431e73478
Gerrit-Change-Number: 77115
Gerrit-PatchSet: 1
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Comment-Date: Thu, 10 Aug 2023 13:53:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment