Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48160 )
Change subject: mb/google/volteer: Add fw_config entries for boot device ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/48160/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48160/1/src/mainboard/google/voltee... PS1, Line 104: PcieRpEnable Ideally, we'd replace these with a pcie chip driver too, and then we could use fw_config to choose whether to configure PCIe ports for NVMe, SATA, etc.
https://review.coreboot.org/c/coreboot/+/48160/1/src/mainboard/google/voltee... PS1, Line 134: SataEnable" = "1" similar here.