Attention is currently required from: Alicja Michalska, Hung-Te Lin, Jarried Lin, Wenzhen Yu, Yidi Lin, Yu-Ping Wu.
Ccong Chen has posted comments on this change by Ccong Chen. ( https://review.coreboot.org/c/coreboot/+/85599?usp=email )
Change subject: soc/meidatek/mt8196: Add SPM loader
......................................................................
Patch Set 9:
(3 comments)
File src/soc/mediatek/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/85599/comment/95164730_b1d1862c?usp... :
PS8, Line 122: version2
Done
File src/soc/mediatek/common/spm.c:
https://review.coreboot.org/c/coreboot/+/85599/comment/50561a0b_ee979b98?usp... :
PS8, Line 30: ptr = (uintptr_t)pcm->buf + SPM_SYSTEM_BASE_OFFSET;
Define SPM_SYSTEM_BASE_OFFSET as 0 in the header file. There's no need to change this. […]
Done
File src/soc/mediatek/mt8196/include/soc/spm.h:
https://review.coreboot.org/c/coreboot/+/85599/comment/48009ce4_09961ad7?usp... :
PS8, Line 66: 0x40000000
This should be 0 for mt8196, right?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85599?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie09346f46cb734c74776b760485e7f35d4357e5e
Gerrit-Change-Number: 85599
Gerrit-PatchSet: 9
Gerrit-Owner: Ccong Chen
ot_ccong.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Wenzhen Yu
wenzhen.yu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alicja Michalska
ahplka19@gmail.com
Gerrit-CC: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Wenzhen Yu
wenzhen.yu@mediatek.corp-partner.google.com
Gerrit-Attention: Alicja Michalska
ahplka19@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 20 Dec 2024 02:25:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alicja Michalska
ahplka19@gmail.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com