Attention is currently required from: Kyösti Mälkki, Alexander Couzens, Patrick Rudolph.
Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55315 )
Change subject: drivers/generic/ioapic: Use register_new_ioapic_gsi0() ......................................................................
Patch Set 8: Code-Review-1
(1 comment)
Patchset:
PS8: This doesn't compile for me (X200):
CC ramstage/drivers/pc80/pc/i8254.o CC ramstage/drivers/pc80/pc/i8259.o CC ramstage/drivers/pc80/pc/isa-dma.o CC ramstage/drivers/pc80/pc/keyboard.o CC ramstage/drivers/mipi/panel.o CC ramstage/drivers/lenovo/wacom.o GCC ramstage/drivers/intel/gma/hires_fb/gma-gfx_init.o CC ramstage/drivers/intel/gma/acpi.o CC ramstage/drivers/intel/gma/edid.o GCC ramstage/drivers/intel/gma/gma.o CC ramstage/drivers/intel/gma/opregion.o CC ramstage/drivers/intel/gma/vbt.o CC ramstage/drivers/i2c/at24rf08c/at24rf08c.o CC ramstage/drivers/i2c/at24rf08c/lenovo_serials.o CC ramstage/drivers/generic/ioapic/ioapic.o src/drivers/generic/ioapic/ioapic.c: In function 'ioapic_init': src/drivers/generic/ioapic/ioapic.c:14:9: error: implicit declaration of function 'register_new_ioapic_gsi0' [-Werror=implicit-function-declaration] 14 | register_new_ioapic_gsi0(config->base); | ^~~~~~~~~~~~~~~~~~~~~~~~ src/drivers/generic/ioapic/ioapic.c: At top level: cc1: note: unrecognized command-line option '-Wno-array-compare' may have been intended to silence earlier diagnostics cc1: all warnings being treated as errors make: *** [Makefile:392: build/ramstage/drivers/generic/ioapic/ioapic.o] Error 1