[coreboot-gerrit] [L] Change in coreboot[main]: mainboard/intel/frost_creek: Add a new CRB Frost Creek for Snow Ridge

[Shuo Liu (Code Review)]

Attention is currently required from: Elyes Haouas, Felix Singer, Jérémy Compostella, Vasiliy Khoruzhick, [e-mail].

Shuo Liu has posted comments on this change by [e-mail]. ( https://review.coreboot.org/c/coreboot/+/83322?usp=email )

Change subject: mainboard/intel/frost_creek: Add a new CRB Frost Creek for Snow Ridge
......................................................................

Patch Set 19:

(7 comments)

File src/mainboard/intel/frost_creek/acpi/mainboard.asl:

https://review.coreboot.org/c/coreboot/+/83322/comment/294c57b7_b50ec74a?usp... :
PS19, Line 10: 		Name(_PRW, Package(){0x1d, 0x05})
S3 is supported?

File src/mainboard/intel/frost_creek/acpi/platform.asl:

https://review.coreboot.org/c/coreboot/+/83322/comment/1768bfb7_a4e14e0e?usp... :
PS19, Line 3: // IO-Trap at 0x800. This is the ACPI->SMI communication interface.
the scope is \SB?

File src/mainboard/intel/frost_creek/board.fmd:

https://review.coreboot.org/c/coreboot/+/83322/comment/1227fd27_aef7169a?usp... :
PS19, Line 2: 	BIOS@0x01400000 0x00C00000 {
can you define the first 20M as a place holder (e.g. IFD, ME, acc firmware)?

https://review.coreboot.org/c/coreboot/+/83322/comment/9392709c_9837b9f9?usp... :
PS19, Line 7: 		COREBOOT(CBFS)@0x51200 0x00baee00
bases could be omitted here if no explicit alignment reqs.

File src/mainboard/intel/frost_creek/gpio.inc:

https://review.coreboot.org/c/coreboot/+/83322/comment/27d94368_4803c419?usp... :
PS19, Line 112: 	SNR_PAD_CFG_STRUCT0(
update the alignments?

File src/mainboard/intel/frost_creek/romstage.c:

https://review.coreboot.org/c/coreboot/+/83322/comment/a5720af6_7d3005ed?usp... :
PS19, Line 20: 	uint32_t boardid = board_id();
do we still need board_id here?

https://review.coreboot.org/c/coreboot/+/83322/comment/d56fb308_344e9761?usp... :
PS19, Line 51: 	for (lane = 0; lane < BL_MAX_FIA_LANES; lane++) {
can you comment here?