[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add ASL functions to manipulate RX/TX buffers

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31619 )

Change subject: soc/intel/cannonlake: Add ASL functions to manipulate RX/TX buffers
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31619/4/src/soc/intel/cannonlake/acpi/gpio_o... 
File src/soc/intel/cannonlake/acpi/gpio_op.asl:

https://review.coreboot.org/#/c/31619/4/src/soc/intel/cannonlake/acpi/gpio_o... 
PS4, Line 112: 	And (Arg1, 1, Arg1)
> This only adds odd side-effects (every other value above 1 means enable / […]

+1. We can just add explicit checks for 0 and 1 and not do anything otherwise.