Attention is currently required from: Jason Glenesk, Marshall Dawson, Jeremy Soller, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59103 )
Change subject: soc/amd/cezanne: enable LPC decodes if platform uses LPC
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/cezanne/early_fch.c:
https://review.coreboot.org/c/coreboot/+/59103/comment/ceb78ef7_565849f7
PS2, Line 50: if (!CONFIG(SOC_AMD_COMMON_BLOCK_USE_ESPI))
Should this be done here at this point? If so can you please capture the reason as a comment so that developers dont move it around accidentally.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59103
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2473fe61b299d1c6221844cd744791b8012c5c67
Gerrit-Change-Number: 59103
Gerrit-PatchSet: 2
Gerrit-Owner: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Nov 2021 06:49:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment