Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55575 )
Change subject: soc/mediatek/mt8195: add mt6691 driver
......................................................................
Patch Set 5:
(2 comments)
File src/soc/mediatek/mt8195/mt6691.c:
https://review.coreboot.org/c/coreboot/+/55575/comment/84ed9389_66914f50
PS3, Line 15: int mt6691_set_voltage(uint8_t i2c_num, unsigned int volt_uv) {
open brace '{' following function definitions go on the next line […]
Done
https://review.coreboot.org/c/coreboot/+/55575/comment/7a7d7f9d_07af3df9
PS3, Line 66: if(!get_mt6691_chip_id(i2c_num)) {
space required before the open parenthesis '(' […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55575
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4fb9f7245d44383a6a3a0cf8d00f7f503cbdeb06
Gerrit-Change-Number: 55575
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 17 Jun 2021 02:26:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment