Attention is currently required from: Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55551 )
Change subject: amdfwtool: Add psp id for combo and ISH header for AB recovery ......................................................................
Patch Set 8:
(32 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/97109bbc_e4fe62e2 PS8, Line 506: uint32_t psp_id; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/b29246ce_80e95f82 PS8, Line 507: switch (soc_id) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/ec4d1884_b7fae5f7 PS8, Line 508: case PLATFORM_RAVEN: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/5a9037bb_18e0db93 PS8, Line 509: case PLATFORM_PICASSO: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/66d6f58c_f38ba77c PS8, Line 510: psp_id = 0xBC0A0000; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/5bb7b8a9_d721e090 PS8, Line 510: psp_id = 0xBC0A0000; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/562e6f4c_ff72012d PS8, Line 511: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/3d2543f0_bc48eb8d PS8, Line 511: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/184ef715_85b9e3cf PS8, Line 512: case PLATFORM_RENOIR: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/58ee9f21_d6b4a1ce PS8, Line 513: case PLATFORM_LUCIENNE: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/9c5d2901_34d5f9bb PS8, Line 514: psp_id = 0xBC0C0000; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/e19f9c0a_b481bc88 PS8, Line 514: psp_id = 0xBC0C0000; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/7222cd2b_a8753fac PS8, Line 515: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/8f02100e_9285e7bd PS8, Line 515: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/90c1d058_e5becb76 PS8, Line 516: case PLATFORM_CEZANNE: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/80be6d9d_c4d3de1a PS8, Line 517: psp_id = 0xBC0C0140; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/6b2ef54b_581c298b PS8, Line 517: psp_id = 0xBC0C0140; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/4f907b47_8cbf59ff PS8, Line 518: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/52e4db26_50f92411 PS8, Line 518: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/7aa3fcfc_964b0a56 PS8, Line 519: case PLATFORM_MENDOCINO: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/02a802d9_b07c5ca6 PS8, Line 521: break; Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/0327bea3_80e0d84b PS8, Line 522: case PLATFORM_STONEYRIDGE: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/35612fe5_ff88d6d4 PS8, Line 523: psp_id = 0x10220B00; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/0553ddef_6b3a439a PS8, Line 523: psp_id = 0x10220B00; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/8002ddd5_fbbae035 PS8, Line 524: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/083c4041_ecf22abe PS8, Line 524: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/d626e15a_e6a466ff PS8, Line 526: psp_id = 0; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/f522584d_67b64965 PS8, Line 526: psp_id = 0; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/259f4fde_cb9cbdaf PS8, Line 527: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/931f67f6_4910a3f8 PS8, Line 527: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/a0890512_f2261fc1 PS8, Line 528: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130379): https://review.coreboot.org/c/coreboot/+/55551/comment/787813d0_6ce3fb76 PS8, Line 529: return psp_id; please, no spaces at the start of a line