Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31370 )
Change subject: [WIP] console: Split loglevel for fast and slow ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31370/1/src/console/init.c File src/console/init.c:
https://review.coreboot.org/#/c/31370/1/src/console/init.c@73 PS1, Line 73: return 0;
Something like that, yes, but simply returning 0 here would wipe out slow consoles entirely.
Right, that wouldn't work. Maybe it's easier to just hardcode this to the CBMEM console rather than trying to have this generic fast/slow split? (Do we ever really expect to have another fast console anyway?) Then you could just do something like this in do_printk()
tx_byte_t tx_byte = wrap_putchar; if (!console_log_level(msg_level)) { if (!IS_ENABLED(CONFIG_CBMEM_CONSOLE)) return 0; tx_byte = wrap_cbmemc_tx_byte; }
and the overall footprint of this patch would be way smaller.
https://review.coreboot.org/#/c/31370/1/src/console/printk.c File src/console/printk.c:
https://review.coreboot.org/#/c/31370/1/src/console/printk.c@34 PS1, Line 34: console_tx_byte(byte);
Yes, old intel MRC. […]
Oh... right, I misread console_write_line(). Okay, I guess those things were never log-level controlled anyway so that doesn't need to change with this patch. Fair enough.