Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun.
sridhar siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80361?usp=email )
Change subject: soc/intel/cmn/sa: Refactor SA common code
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/meteorlake/include/soc/systemagent.h:
https://review.coreboot.org/c/coreboot/+/80361/comment/09ee6f0d_7933cff2 :
PS2, Line 55: #define MASK_DSM_LENGTH 0xFF00 // [15:8]
: #define MASK_DSM_LENGTH_LSB 8 // used to shift right
: #define MASK_GSM_LENGTH 0xC0 // [7:6]
: #define MASK_GSM_LENGTH_LSB 6 // used to shift right
: #define MASK_DPR_LENGTH 0xFF0 // [11:4]
: #define MASK_DPR_LENGTH_LSB 4 // used to shift right
nit: here too,, alignment issue(lines#55, #57, #59)? […]
No issues!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80361?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I476f213d75a0978336b3749a5ba1499107eb2238
Gerrit-Change-Number: 80361
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 08 Feb 2024 15:15:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-MessageType: comment