Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, Cliff Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jeff Daly, Jincheng Li, Johnny Lin, Jonathan Zhang, Kapil Porwal, Lance Zhao, Lean Sheng Tan, Nick Vaccaro, Nico Huber, Patrick Rudolph, Paul Menzel, Sean Rhodes, Shuo Liu, Subrata Banik, Tarun, Tim Chu, Tim Wawrzynczak, Vanessa Eusebio, Werner Zeh.
Angel Pons has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/82429?usp=email )
Change subject: acpi: Add support for DRHD size reporting
......................................................................
Patch Set 16: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82429/comment/0c35a242_46978c17?usp... :
PS15, Line 11: the register set is 2^N 4 KB pages.
When N is zero, the size would be 2^0 4KB pages, a.k.a. […]
Ack, thanks for confirming.
File src/acpi/acpi_dmar.c:
https://review.coreboot.org/c/coreboot/+/82429/comment/99217151_f2d1cbe6?usp... :
PS16, Line 42: u16 segment, u64 bar)
nit:
```suggestion
u16 segment, u64 bar)
```
https://review.coreboot.org/c/coreboot/+/82429/comment/e82b9b96_d9f63166?usp... :
PS16, Line 44: 1
Since you kept the `size` parameter in bytes:
```suggestion
return acpi_create_dmar_drhd(current, flags, segment, bar, 4 * KiB);
```
https://review.coreboot.org/c/coreboot/+/82429/comment/b5080575_2c65d4ca?usp... :
PS16, Line 48: u16 segment, u64 bar, u32 size)
nit:
```suggestion
u16 segment, u64 bar, u32 size)
```
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/82429/comment/301de44b_be82648f?usp... :
PS15, Line 1852: unsigned long acpi_create_dmar_drhd(unsigned long current, u8 flags,
: u16 segment, u64 bar, u32 size);
I made some attempts between using npages or size, and didn't get clear benefit of using npages bec […]
Hmmm, okay, let's keep it as-is for now. It's not too bad given that existing code now uses `acpi_create_dmar_drhd_4k`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82429?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I49dd5de2eca257a5f6240e36d05755cabca96d1c
Gerrit-Change-Number: 82429
Gerrit-PatchSet: 16
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Comment-Date: Tue, 25 Jun 2024 08:53:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com