Masanori Ogino has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45927 )
Change subject: nb/intel/*/memmap.c: Use `postcar_frame_add_cbmem_top` ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Thank you for your prompt answers, Angel! Feel free to mark my comments as resolved when the patchset is revised.
https://review.coreboot.org/c/coreboot/+/45927/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/memmap.c:
https://review.coreboot.org/c/coreboot/+/45927/2/src/northbridge/intel/sandy... PS2, Line 41: uintptr_t top_of_ram = (uintptr_t)cbmem_top();
Thanks for noticing. […]
Ack
https://review.coreboot.org/c/coreboot/+/45927/2/src/northbridge/intel/sandy... PS2, Line 49: postcar_frame_add_cbmem_top(pcf, 8 * MiB, 1);
There's no change of alignment. The original code did not align `top_of_ram` at all. […]
I see. Thank you for your explanation.