23 Oct
2019
23 Oct
'19
9:31 a.m.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36260 )
Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................
Patch Set 2: Code-Review+2
"A device object must contain either an _HID object or an _ADR object, but should not contain both"
Some of the true legacy superio devices do need _ADR but not the ones with a PNP ID.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36260
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4
Gerrit-Change-Number: 36260
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-Comment-Date: Wed, 23 Oct 2019 16:31:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment