Attention is currently required from: Reka Norman, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 )
Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60379/comment/fa575b55_cd37b3a5
PS1, Line 17: brya remains identical
Hi Felix, do you mean deleting the .config and and auto generate the .config by menuconfig ? […]
I'm blind, sorry. I thought you are adding a new config option, which would change the .config file. Done :)
How about "coreboot.rom remains the same"?
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/60379/comment/34f8ad3f_1bd6e3af
PS2, Line 25: def_bool y
default n here?
Can be just removed then. Another possibility would be moving the whole thing out here. This would also align the Kconfig file with the other Google mainboards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60379
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e
Gerrit-Change-Number: 60379
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Reka Norman
rekanorman@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Sat, 25 Dec 2021 17:31:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment