[coreboot-gerrit] [XL] Change in coreboot[main]: soc/ptl/acpi: Add SoC ACPI directory for Panther Lake

[Saurabh Mishra (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Jamie Ryu, Ravishankar Sarawadi, Subrata Banik, Wonkyu Kim.

Saurabh Mishra has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/83772?usp=email )

Change subject: soc/ptl/acpi: Add SoC ACPI directory for Panther Lake
......................................................................

Patch Set 25:

(9 comments)

Patchset:

PS24:
> Please push ACPI changes post GPIO.

Ack, update the chain.

File src/soc/intel/pantherlake/acpi/pcie.asl:

https://review.coreboot.org/c/coreboot/+/83772/comment/3e60d792_1fa7abd4?usp... :
PS23, Line 237: Name (_ADR, 0x001D0000)
> i really don't understand what is the source of truth that your are following ? […]

Hi Subrata, we have reviwed this change to be corrected, but looks like the patch missed to add the changes. i have added the required correction.

https://review.coreboot.org/c/coreboot/+/83772/comment/03629be5_04db3571?usp... :
PS23, Line 254: Name (_ADR, 0x001D0001)
>

Acknowledged

File src/soc/intel/pantherlake/acpi/serialio.asl:

https://review.coreboot.org/c/coreboot/+/83772/comment/ecc45be0_d4b4b895?usp... :
PS23, Line 59:
> empty line

Acknowledged

File src/soc/intel/pantherlake/acpi/southbridge.asl:

https://review.coreboot.org/c/coreboot/+/83772/comment/8887933e_7858b403?usp... :
PS23, Line 10:
> you still need this IMO because of 2nd P2SB device […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/83772/comment/41c80314_1ec6ee2e?usp... :
PS23, Line 11: /* PCH clock */
> missing  […]

Acknowledged

File src/soc/intel/pantherlake/acpi/tcss.asl:

https://review.coreboot.org/c/coreboot/+/83772/comment/a4831cd4_3f557f38?usp... :
PS23, Line 397: 0xE0800000
> what is this hardcoded value ? IOM_BASE_ADDR is what you need here […]

corrected.

File src/soc/intel/pantherlake/acpi/tcss_pcierp.asl:

https://review.coreboot.org/c/coreboot/+/83772/comment/a05e2a38_cbbcc169?usp... :
PS23, Line 28:
> tab?

Acknowledged

https://review.coreboot.org/c/coreboot/+/83772/comment/09a3999a_838017c0?usp... :
PS23, Line 33:
> please try to be consistent with space and tab

Acknowledged