Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Jamie Ryu, Subrata Banik.
Felix Held has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84104?usp=email )
Change subject: soc/intel/common/block/pmc: Add GPE1 functions ......................................................................
Patch Set 11:
(1 comment)
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/84104/comment/3014395b_547cf831?usp... : PS11, Line 68: /* SoC overrides for GPE1 when SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1 is enabled */ : __weak const char *const *soc_std_gpe1_sts_array(int idx, size_t *a) : { : return NULL; : } : : /* disable the corresponding GPE1 bits based on standard GPE0 bits */ : __weak void soc_pmc_disable_std_gpe1(uint32_t gpe0_mask) : { : } : : /* enable the corresponding GPE1 bits based on standard GPE0 bits */ : __weak void soc_pmc_enable_std_gpe1(uint32_t gpe0_mask) : { : }
These __weak functions are meant for SOCs with no SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1 being being […]
i just tested removing the weak functions and building a board that selects SOC_INTEL_COMMON_BLOCK_ but doesn't select SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1 and as i expected that compiled and linked without error, so those weak functions aren't needed