Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Subrata Banik.
hualin wei has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/83906?usp=email )
Change subject: mb/google/dedede/var/awasuki: Adjust I2C frequency to less than 400 KHz
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS3:
Why change the max not the parameter?
Done
File src/mainboard/google/dedede/variants/awasuki/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83906/comment/d622a933_497de245?usp... :
PS3, Line 38: I2C_SPEED_FAST - 30000
should follow the defined template as per I2C spec. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83906?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb75db1dc95ffd5ca806a194ae678c700fa0741c
Gerrit-Change-Number: 83906
Gerrit-PatchSet: 5
Gerrit-Owner: hualin wei
weihualin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 16 Aug 2024 02:02:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com