[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Do initial SoC commit

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36087 )

Change subject: soc/intel/tigerlake: Do initial SoC commit
......................................................................

Patch Set 8:

Why do we have two copies of this change? Here is what I already
commented on CB:33568.
> Patch Set 2: Code-Review-1
>
> Copying whole directories at once leads to an incredible code
> degradation. Obviously, nobody is going to do a 8.6KLOC code
> review. Which leaves a lot of code in place that was meant for
> an older chip but doesn't apply to the new one.
>
> I spot at least once a week some code in soc/intel/cannonlake/
> that doesn't belong there. And wouldn't be there if there
> wasn't this copy-paste practice. This code, copied from SKL,
> that doesn't apply to CNL has already been copied to ICL where
> it most likely doesn't apply either. Now you want to copy it
> to TGL???