Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43517 )
Change subject: 3rdparty/vboot: Update submodule pointer to upstream master
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43517/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43517/1//COMMIT_MSG@9
PS1, Line 9: Building depthcharge master currently fails as depthcharge commit 74ca8ae5
depthcharge ToT should always compile against CrOS coreboot and vboot_reference ToT. […]
Right, but building google/sarien with the current vboot tag is not possible because of a linker error (fixed in the change I linked above). I wonder why the builders didn't catch that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43517
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd5408fb824fc5da470774b7f493b916dff17832
Gerrit-Change-Number: 43517
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 27 Jul 2020 13:13:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment