Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36274 )
Change subject: arch/x86: Save the calling argument ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36274/10/src/arch/x86/c_start.S File src/arch/x86/c_start.S:
https://review.coreboot.org/c/coreboot/+/36274/10/src/arch/x86/c_start.S@23 PS10, Line 23: .quad 0 You probably want to move this to a different part of the .bss section. Otherwise we'll be stranding CONFIG_STACK_SIZE - sizeof(quad). Alternatively provide a different section name like '.bss._cbmem_top_ptr' for this object. That way it can be put anywhere within the resulting bss section. You might want to provide alignment expectations as well (unless .quad assumes 8 byte alignment) and the object is marked as such.