Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35545 )
Change subject: soc/intel/(apl,skl,cnl,common): Move mkhi_hdr structure defination to common ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35545/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35545/3//COMMIT_MSG@7 PS3, Line 7: defination definition
https://review.coreboot.org/c/coreboot/+/35545/3//COMMIT_MSG@9 PS3, Line 9: defination definition
https://review.coreboot.org/c/coreboot/+/35545/3//COMMIT_MSG@9 PS3, Line 9: mkhs_hdr mkhi_hdr
https://review.coreboot.org/c/coreboot/+/35545/3/src/soc/intel/apollolake/cs... File src/soc/intel/apollolake/cse.c:
https://review.coreboot.org/c/coreboot/+/35545/3/src/soc/intel/apollolake/cs... PS3, Line 188: fw_version_cmd nit: if it's only the header that is sent, we do not need this encapsulation.