Attention is currently required from: Paul Menzel, Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59497 )
Change subject: libpayload: Implement new CBFS access API ......................................................................
Patch Set 11:
(5 comments)
File payloads/libpayload/include/cbfs_boot_device.h:
PS8:
Will be merged again with cbfs_glue. […]
Done
File payloads/libpayload/libcbfs/cbfs.c:
https://review.coreboot.org/c/coreboot/+/59497/comment/7f64d021_f1147c54 PS3, Line 60: void cbfs_boot_device_find_mcache(struct cbfs_boot_device *cbd, bool is_ro);
I marked it as static. Please take a look at current solution (in tests too).
Done
File payloads/libpayload/libcbfs/cbfs.c:
https://review.coreboot.org/c/coreboot/+/59497/comment/20f99be6_9457dc14 PS8, Line 172: if (!size_inout || *size_inout < out_size)
nit: might want to print an error here too?
Done
File payloads/libpayload/libcbfs/cbfs.c:
https://review.coreboot.org/c/coreboot/+/59497/comment/e0c2027a_af655975 PS10, Line 17: static struct cbfs_boot_device rw;
nit: Don't really see why you moved these out of the function? I mean it works this way, but it work […]
I did it to make testing easier. However, I found a way to test it without making it outside of the function, so it is now back inside.
File payloads/libpayload/tests/libcbfs/cbfs-lookup-test.c:
PS1:
I'm re-writing this test to mock-out all commonlib dependencies and to cover all of the new API.
Done