[coreboot-gerrit] [S] Change in coreboot[master]: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP

[Felix Held (Code Review)]

Attention is currently required from: Arthur Heymans, Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Patrick Rudolph, Tim Chu.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61164 )

Change subject: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP
......................................................................

Patch Set 2:

(1 comment)

File src/soc/intel/xeon_sp/cpx/Kconfig:

https://review.coreboot.org/c/coreboot/+/61164/comment/8690cd72_a56db07b 
PS2, Line 87: config BROKEN_FSP_NEEDS_STACK_ABOVE_BSS
the kconfig option should probably be put into src/arch/x86/Kconfig to be in the same scope as the file that it'll affect, be default n, and the option then be selected in src/soc/intel/xeon_sp/cpx/Kconfig to have the override for that case. otherwise the option will only be defined for this soc, but used in common code. sure, the current implementation will end up working, since the kconfig default is n, but it would be nicer to have it in a better place