Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48283 )
Change subject: lib/cbfs.c: Update the ro bootdevice in CBMEM init in romstage ......................................................................
Patch Set 1:
(2 comments)
Does this solve any specific problem? I thought CAR stays valid until the end of romstage on all platforms these days? Or do we still use the CAR migration code in romstage somewhere (then this would probably need to be integrated in there somehow)?
https://review.coreboot.org/c/coreboot/+/48283/1/src/lib/cbfs.c File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/48283/1/src/lib/cbfs.c@489 PS1, Line 489: printk(BIOS_DEBUG, "CBMEM_MCACHE 0x%08lx\n", (uintptr_t)cbmem_mcache); Does it make sense to land this line permanently? The mcache regions already get printed as part of the CBMEM table at the end of ramstage.
https://review.coreboot.org/c/coreboot/+/48283/1/src/lib/cbfs.c@498 PS1, Line 498: ro.mcache_size = real_size; With vboot this function is called for both RO and RW mcache so this should probably go in cbfs_mcache_migrate() instead, or it needs to be guarded with a cbmem_id check.