Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83922?usp=email )
Change subject: soc/mediatek/mt8196: Add GPIO driver ......................................................................
Patch Set 6:
(3 comments)
File src/soc/mediatek/mt8196/gpio.c:
https://review.coreboot.org/c/coreboot/+/83922/comment/7af524ca_bcee1d14?usp... : PS4, Line 393: return NULL;
Log an error?
Done
https://review.coreboot.org/c/coreboot/+/83922/comment/560a5e52_ade19ea1?usp... : PS4, Line 400: return NULL;
Ditto.
Done
File src/soc/mediatek/mt8196/include/soc/gpio_base.h:
PS4:
It’s identical to `src/soc/mediatek/mt8195/include/soc/gpio_base.h`.
This .h file is included by common/soc, but 8173 uses a different gpio_base from the others. Currently, I am thinking of possibly using config to separate it, but this should not be a good approach in common code. Do you have any better ideas?