[coreboot-gerrit] Change in coreboot[master]: mb/google/brya: set GPP_D0 to GPO and unlocked

[Wisley Chen (Code Review)]

Attention is currently required from: YH Lin, Nick Vaccaro, Eric Lai, Zhuohao Lee, Mark Hsieh, EricR Lai, Felix Held.
Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62739 )

Change subject: mb/google/brya: set GPP_D0 to GPO and unlocked
......................................................................

Patch Set 4:

(1 comment)

File src/mainboard/google/brya/variants/baseboard/brya/gpio.c:

https://review.coreboot.org/c/coreboot/+/62739/comment/9adc46eb_edf7309b 
PS2, Line 122: 	/* D1  : ISH_GP1 ==> FP_RST_ODL */
             : 	PAD_CFG_GPO_LOCK(GPP_D1, 1, LOCK_CONFIG),
             : 	/* D2  : ISH_GP2 ==> EN_FP_PWR */
             : 	PAD_CFG_GPO_LOCK(GPP_D2, 1, LOCK_CONFIG),
> Wisley, redrix didn't lock the GPIO setting. https://review.coreboot. […]

for redrix, add lock_config for D1/D2/D3

diff --git a/src/mainboard/google/brya/variants/baseboard/brya/gpio.c b/src/mainboard/google/brya/variants/baseboard/brya/gpio.c
index b8d1761fde..da0048aac2 100644
--- a/src/mainboard/google/brya/variants/baseboard/brya/gpio.c
+++ b/src/mainboard/google/brya/variants/baseboard/brya/gpio.c
@@ -118,7 +118,7 @@ static const struct pad_config gpio_table[] = {
        PAD_CFG_GPI_APIC(GPP_C7, NONE, PLTRST, LEVEL, NONE),

/* D0  : ISH_GP0 ==> PCH_FP_BOOT0 */
-       PAD_NC_LOCK(GPP_D0, NONE, LOCK_CONFIG),
+       PAD_CFG_GPO_LOCK(GPP_D0, 0, LOCK_CONFIG),
        /* D1  : ISH_GP1 ==> FP_RST_ODL */
        PAD_CFG_GPO_LOCK(GPP_D1, 1, LOCK_CONFIG),

diff --git a/src/mainboard/google/brya/variants/redrix/gpio.c b/src/mainboard/google/brya/variants/redrix/gpio.c
index c89d58c3fa..11a4571a0a 100644
--- a/src/mainboard/google/brya/variants/redrix/gpio.c
+++ b/src/mainboard/google/brya/variants/redrix/gpio.c
@@ -97,9 +97,9 @@ static const struct pad_config early_gpio_table[] = {
         * later on in ramstage. Since reset signal is asserted in bootblock, it results in
         * FPMCU not working after a S3 resume. This is a known issue.
         */
-       PAD_CFG_GPO(GPP_D1, 0, DEEP),
+       PAD_CFG_GPO_LOCK(GPP_D1, 0, LOCK_CONFIG),
        /* D2  : ISH_GP2 ==> EN_FP_PWR */
-       PAD_CFG_GPO(GPP_D2, 1, DEEP),
+       PAD_CFG_GPO_LOCK(GPP_D2, 1, LOCK_CONFIG),

localhost ~ # echo 0 > /sys/class/gpio/gpio312/value 
localhost ~ # iotools mmio_read32 0xfd6d0900   
0x04000200
localhost ~ # echo 1 > /sys/class/gpio/gpio312/value 
localhost ~ # iotools mmio_read32 0xfd6d0900
0x04000201
localhost ~ # echo 0 > /sys/class/gpio/gpio313/value 
localhost ~ # iotools mmio_read32 0xfd6d0910
0x04000200
localhost ~ # echo 1 > /sys/class/gpio/gpio313/value 
localhost ~ # iotools mmio_read32 0xfd6d0910
0x04000201
localhost ~ # echo 0 > /sys/class/gpio/gpio314/value 
localhost ~ # iotools mmio_read32 0xfd6d0920
0x04000200
localhost ~ # echo 1 > /sys/class/gpio/gpio314/value 
localhost ~ # iotools mmio_read32 0xfd6d0920
0x04000201