Attention is currently required from: Anil Kumar K, Bora Guvendik, Martin L Roth, Subrata Banik, Wonkyu Kim.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84107?usp=email )
Change subject: payloads/depthcharge: Add default 64-bit libpayload config ......................................................................
Patch Set 4:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84107/comment/c206413e_570eed17?usp... : PS1, Line 11:
please state the problem statement clearly here to make the code review easy?
sure. will do. thx!
https://review.coreboot.org/c/coreboot/+/84107/comment/c5d00dc9_d569e246?usp... : PS1, Line 12: BUG=
BUG=none
Acknowledged
File payloads/external/depthcharge/Kconfig:
https://review.coreboot.org/c/coreboot/+/84107/comment/3b3792fc_a9d429ea?usp... : PS1, Line 65: LP_DEFCONFIG64_OVERRIDE
nit […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/84107/comment/cec78ba7_78b210d8?usp... : PS1, Line 69: The Depthcharge makefile looks for a file config.<boardname> in the : libpayload/configs directory. Say Y here to use the file defconfig : instead. This is can be a convenience for development purposes, or : if the defaults in defconfig are sufficient for your system.
this should somehow convey that one needs to select this config to boot a 64-bit payload […]
Acknowledged
File payloads/external/depthcharge/Makefile:
https://review.coreboot.org/c/coreboot/+/84107/comment/59df6fdb_e105e363?usp... : PS1, Line 34: defconfig64
use a `_` between defconfig and 64?
Acknowledged
File payloads/libpayload/configs/defconfig64:
https://review.coreboot.org/c/coreboot/+/84107/comment/c58cee3d_feaaad9a?usp... : PS1, Line 3: CONFIG_LP_ARCH_X86_32=n
just comment out may be. we don't use `n` to assign to a Kconfig. […]
Acknowledged