Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43464 )
Change subject: mb/amd/mandolin/.../sleep.asl: Remove unnecessary variable ......................................................................
mb/amd/mandolin/.../sleep.asl: Remove unnecessary variable
There is no reason to create a named variable. We can just return the package.
BUG=b:153001807, b:154756391 TEST=None
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: Ic0ca2e6d4fb833c68d29e9948a670ace7c89b6a5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43464 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/amd/mandolin/acpi/sleep.asl 1 file changed, 1 insertion(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/acpi/sleep.asl b/src/mainboard/amd/mandolin/acpi/sleep.asl index 89c6fa1..db81e4a 100644 --- a/src/mainboard/amd/mandolin/acpi/sleep.asl +++ b/src/mainboard/amd/mandolin/acpi/sleep.asl @@ -1,8 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* Wake status package */ -Name(WKST,Package(){Zero, Zero}) - /* * _PTS - Prepare to Sleep method * @@ -25,10 +22,7 @@ /* DBGO(Arg0) */ /* DBGO("\n") */
- /* Clear wake status structure. */ Store(0, PEWD) - Store(0, Index(WKST,0)) - Store(0, Index(WKST,1)) Store(7, UPWS) } /* End Method(_PTS) */
@@ -53,5 +47,5 @@ /* DBGO(Arg0) */ /* DBGO(" to S0\n") */
- Return(WKST) + Return(Package(){Zero, Zero}) } /* End Method(_WAK) */