Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31420 )
Change subject: SMBIOS: Update Processor Information structure to v3.2.0 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31420/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31420/2/src/arch/x86/smbios.c@564 PS2, Line 564: t->core_count2 = (res.ebx >> 16) & 0xffff; The field is still only 8 bits. See cpuid leaf 1 docu- mentation in SDM vol. 2.
Not for this change, but for the future: This field doesn't accurately represent the number of cores. It is how many different APIC (core) IDs the processor supports which may be more than the number of actual cores. One solution would be to call into platform specific code to get the actual core count (some- where in MP init it should be already known).