Attention is currently required from: Christian Walter, Maximilian Brune, Nico Huber, Philipp Hug, ron minnich.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68843?usp=email )
Change subject: mb/emulation/riscv: Limit DRAM size
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
We could probably read the DRAM regions from dtb or fw_cfg. Looking at current
QEMU code the riscv `virt' machine seems to support both. Though, I couldn't
figure out the details. Support for the latter currently lives in the x86
board ports, but could probably be moved into drivers/.
Reading dtb in romstage is painful. The fdt libraries in coreboot are from depthcharge which unflattens it using heap, which is not available in romstage. Maybe we should think about importing libfdt in coreboot which is better for just parsing it which we need here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68843?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib8555de361d1129d3d1995f056518c576f055515
Gerrit-Change-Number: 68843
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 06 Feb 2024 08:05:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: ron minnich
rminnich@gmail.com
Gerrit-MessageType: comment