Attention is currently required from: Jason Glenesk, Marshall Dawson, Kangheui Won, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58316 )
Change subject: psp_verstage: convert relative address in EFS2 ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58316/comment/5bad6899_55036607 PS1, Line 10: update_psp_bios_dir Can you update the documentation on update_psp_bios_dir to say that it only accepts x86 absolute addresses?
File src/soc/amd/common/psp_verstage/include/psp_verstage.h:
https://review.coreboot.org/c/coreboot/+/58316/comment/64611816_be1f0ce7 PS1, Line 46: Can you tab the values
File src/soc/amd/common/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/58316/comment/abfedf9d_426145b9 PS1, Line 126: (ef_table->efs_gen & EFS_GEN_MASK) == EFS_GEN2 EFS2 uses a version of 0? What's the current value of the reserved1 field? Will this always be true?
https://review.coreboot.org/c/coreboot/+/58316/comment/2921cc96_0b25d8ce PS1, Line 131: (void *) Why the void* cast?