Attention is currently required from: Nico Huber, Maxim Polyakov, Paul Menzel, Angel Pons, Andrey Petrov.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62889 )
Change subject: soc/intel/apollolake: Correct enum for PrimaryVideoAdaptor FSP parameter
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/apollolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/62889/comment/50b8eee6_96073d0d
PS2, Line 236: GPU_PRIMARY_PCI
Does the external PCIe GPU work too?
I will have access to an Intel CRB in two weeks and will test to be sure.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62889
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedbc144fa809f6d4587f5223b235ee95579c48f7
Gerrit-Change-Number: 62889
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Fri, 18 Mar 2022 07:09:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-MessageType: comment