Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34358 )
Change subject: haswell: reinitialize EHCI debug hardware after raminit ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34358/2/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/raminit.c:
https://review.coreboot.org/c/coreboot/+/34358/2/src/northbridge/intel/haswe... PS2, Line 159: if (rv) { : switch (rv) { : case -1: : printk(BIOS_ERR, "PEI version mismatch.\n"); : break; : case -2: : printk(BIOS_ERR, "Invalid memory frequency.\n"); : break; : default: : printk(BIOS_ERR, "MRC returned %x.\n", rv); : } : die_with_post_code(POST_INVALID_VENDOR_BINARY, : "Nonzero MRC return value.\n"); : } It would be nice to ensure this (which is rather important IMHO) gets printed out to the usbdebug gadget.
https://review.coreboot.org/c/coreboot/+/34358/2/src/northbridge/intel/haswe... PS2, Line 174: die("UEFI PEI System Agent not found.\n"); This one gets printed out fine, as mrc has not run if we're on this path.