Attention is currently required from: Nick Vaccaro, Raj Astekar, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/83787?usp=email )
Change subject: mb/google/brox: Control HDMI Hot Plug Detect(HPD) during S0ix
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brox/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83787/comment/263aa51b_4f6ee502?usp... :
PS1, Line 18:
: #define HDMI_HPD GPP_A18
can we move this macro inside https://github. […]
I am holding this CL since Intel GPIO architecture team does not recommend switching the pad mode from GPIO to Native Function back and forth.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83787?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8d95f1d5e1286896c026405ac528dcc084cfa931
Gerrit-Change-Number: 83787
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raj Astekar
raj.astekar@intel.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 12 Aug 2024 20:55:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com