Attention is currently required from: Julius Werner, Maximilian Brune, Philipp Hug, ron minnich.
Nico Huber has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/84087?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: fit_payload: Use our region API
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Copying from CB:79907 so it's not forgotten:
It's um, a bit ugly: CB:84087. We don't have an API to manipulate regions
and the FIT code uses the struct to first only pass some offsets and sizes
around, patching them until it's a region. Not sure if we should extend the
API or live with it. For now, I've done everything with region_create().
Also not sure if the data is considered truted. In case of vboot, does the
CBFS API take care of verification?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84087?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0b4cbd5bd38832036a765952b6fec2af5e63f541
Gerrit-Change-Number: 84087
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 26 Aug 2024 10:07:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No