[coreboot-gerrit] [XS] Change in coreboot[master]: soc/intel/meteorlake: Allow mainboard to configure c1-state auto-demo...

[Paul Menzel (Code Review)]

Attention is currently required from: Kapil Porwal, Subrata Banik, Sukumar Ghorai, Tarun Tuli.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76826?usp=email )

Change subject: soc/intel/meteorlake: Allow mainboard to configure c1-state auto-demotion
......................................................................

Patch Set 3:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/76826/comment/36a8eb96_66e8fc74 :
PS3, Line 7: Allow mainboard to configure c1-state auto-demotion
Maybe:
> Hook up UPD for C1 C-state auto-demotion

https://review.coreboot.org/c/coreboot/+/76826/comment/e3430f34_e774a019 :
PS3, Line 12: This patch hooks up this parameter to devicetree
Please add a dot/period at the end.

File src/soc/intel/meteorlake/chip.h:

https://review.coreboot.org/c/coreboot/+/76826/comment/bef41fdd_554d9169 :
PS3, Line 372: 	 * Enable or Disable C1 C-state Auto Demotion.
Maybe add, what that does?

https://review.coreboot.org/c/coreboot/+/76826/comment/2f851d61_92ff0f2d :
PS3, Line 373: C-state
C1 C-state