Attention is currently required from: Christian Walter, Julius Werner, Jérémy Compostella, Martin L Roth, Michał Żygowski, Sergii Dmytruk.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69159?usp=email )
Change subject: security/tpm: make tis_probe() return tpm_family
......................................................................
Patch Set 23:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69159/comment/96762192_ad938657 :
PS23, Line 9:
Nit: double space
File src/drivers/i2c/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/47f4f456_4653c9c3 :
PS1, Line 461: *tpm_family = 1;
To revive this thread: even if this driver (`tpm. […]
It seems that this is the sanest way to go, but please add a comment explaining it above the lines wherever version is set unconditionally.
File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/9313186c_e6dd8dbf :
PS23, Line 718: int
This is no longer int.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69159?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5006e0cdfef76ff79ce9e1cf280fcd5515ae01b0
Gerrit-Change-Number: 69159
Gerrit-PatchSet: 23
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Mon, 12 Feb 2024 12:51:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment