awokd@danwin1210.me has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36081 )
Change subject: vc/amd/agesa/f16kb: Cast to UINT64 to avoid overflow ......................................................................
Patch Set 5:
(1 comment)
Patch Set 4:
could add a sanity check instead of the cast?
I think I can, but Coverity would still complain, right? There are "intentional" and "bug" categories in Coverity. Would you prefer a sanity check + "intentional" vs. a cast + "bug"? I am fine with either as long as Coverity no longer claims it as an outstanding issue.
https://review.coreboot.org/c/coreboot/+/36081/2/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/DMI/mfDMI.c:
https://review.coreboot.org/c/coreboot/+/36081/2/src/vendorcode/amd/agesa/f1... PS2, Line 719: uint64_t
Though the AGESA types are more ugly, it's probably better to use UINT64 for consistency.
Done