Attention is currently required from: Michał Kopeć, Felix Held.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59934 )
Change subject: [TESTME] sb/amd/pi/hudson/early_init: fix setting SPI_USE_SPI100 in SPI100_ENABLE
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
SPIx20 register in BKDG describes only the bit0 (SPI100_ENABLE), the rest is reserved. It is still wise though to set only the known bits.
MIchał, the flash used on apu2 can support 104MHz so the test would really be reliable if called hudson_set_spi(SPI_SPEED_100M, SPI_SPEED_100M, SPI_SPEED_100M, SPI_SPEED_100M);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbd960a9509542b28f03326a3066995540260bef
Gerrit-Change-Number: 59934
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 07 Dec 2021 10:38:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment